-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't return service in list of profilable JVM processes #21
Comments
Hey @RichardH92 , I'm working on getting the build system working in #17 so we can easily build and run JCoz. Once that's done, this might be a good starter bug for you |
The basic idea here is that when the RMI service uses the VirtualMachine API to find a list of processes (see https://github.com/Decave/JCoz/blob/master/src/java/src/main/java/com/vernetperronllc/jcoz/service/JCozServiceImpl.java#L68), it should not return itself in that list. We are also going to need a way to determine which of those services is running with the JCoz native agent and only return those rather than any other JVM process. |
Note that #24 is slightly different from this bug because we should not be returning the same RMI service even if for some reason it is being profiled by JCoz. |
So, I have been researching. I think to accomplish this and the other related issue #24, we will need to use Then, when calling |
Nice, that should work. You'll have to figure out how to call it (or something equivalent) from the native JVMTI layer. Something along the lines of http://www.hildstrom.com/projects/jni/index.html should work. You don't have to create the JNI environment - you can just call it from here: https://github.com/Decave/JCoz/blob/master/src/native/entry.cc#L229. Hopefully the SecurityManager won't get in your way. Also, let's name the property something unique to JCoz, like |
Fixes #21 Once upon a time, it was under consideration to try and monetize JCoz. This is no longer the case, and JCoz is free and open source under the permissions afforded by the GPL. This change therefore removes references to vernetperronllc, and restructures the layout of the Java portion of JCoz accordingly. Testing Done: Verified that java and tests make targets can still be built, and that docker image can still be built.
Currently when you query a service for a list of JCozVMDescriptors, it also sends itself as an available process. We should not include the service in this list.
The text was updated successfully, but these errors were encountered: