Strict record handling #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request! Can you please add some tests |
Conflicts: lib/parser_stream.js test/fast-csv.test.js
… cases where there are too few columns provided
|
Added testcase to describe the intended behavior and updated to the latest HEAD |
… cases where there are too few columns provided
Conflicts: test/parsing.test.js
| assert.deepEqual(actual, expected25_invalid); | ||
| reachedInvalid = true; | ||
| }) | ||
| .on("error", function(e){console.log(e)}) |
There was a problem hiding this comment.
We should error on here you can just do on("error", next)
There was a problem hiding this comment.
Fixed with e859b69
Thanks
|
Other than my one comment this looks good Ill merge once fixed. Thanks again |
doug-martin
added a commit
to doug-martin/fast-csv
that referenced
this pull request
Mar 3, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have the requirement to fail if the records are incomplete. Up to now, fast-csv is quite polite and just consideres an incomplete line as the first field/property and continues.
A workaround wouuld be to check in the validate function if the row is incomplete. but based on the amount of fields, it is very complex to identify a record which may have some fields left empty (which might be valid) and some literally missing.
Therefore introduced a new property (on default, the existing behavior remains unchanged) to emit data-invalid events on incomplete rows.