This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
problems with the new "isolated" option #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 24, 2014 12:04
| @@ -583,7 +583,7 @@ var Database = define(null, { | |||
| self.__transaction(null, opts, cb).chain(ret.callback, ret.errback); | |||
| }; | |||
| this.__transactionQueue.enqueue(transaction); | |||
| return ret.promise(); | |||
| return ret; | |||
There was a problem hiding this comment.
Please change this back to ret.promise() this ensures that invoking code cannot resolve the promise.
|
Thanks for the pull request! Other than my comments it looks good once those are addressed I will merge. |
|
ok I've reverted those two changes. I'm used to the callback style, so I'm all but an expert with promises... just a question though: shouldn't line 575 changed into a return too? |
doug-martin
added a commit
that referenced
this pull request
Apr 25, 2014
problems with the new "isolated" option
doug-martin
added a commit
to doug-martin/patio
that referenced
this pull request
Apr 25, 2014
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes a typo for the new option (called "isolate" in the code but "isolated" in the documentation) and should fix some problems with these new transactions.