Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Topic/validator options #68

Merged
merged 4 commits into from
Sep 30, 2013
Merged

Topic/validator options #68

merged 4 commits into from
Sep 30, 2013

Conversation

jordan-ayers
Copy link
Contributor

I ran into a case at work where using:
validate("column-name").isUUID( { onlyNotNull: true } );
would reject an update on a loaded model with "'column-name' must be a valid UUID got null".

I don't have 'make test' working at home yet, but the logic change to enable the option was simple enough. Letting 'onlyDefined === false' override onlyNotNull in case of a conflict seemed best.

@jordan-ayers
Copy link
Contributor Author

Test cases added and now passing on the nodejs 0.6 build on Travis.
Nodejs 0.8 build is failing in a similar fashion to my own system (running 0.10), but that issue appears to have been present before my changes.

@jordan-ayers
Copy link
Contributor Author

Association tests pass here now if I move them to the end of the test sequence (renaming test/associations to test/z_associations). This might clean the errors on Travis, but seems a bit crude. Still have two assert errors in "patio" test sections, and am unable to run MySQL adaptor tests.

@doug-martin
Copy link
Contributor

Ok so all the tests are passing Im not quite sure what was going on but while I was checking that out I updated to the latest mysql and postgres modules and update the travis tests to use v0.10 and removed support for v0.6 because of the postgres update. If you could try running this locally and let me know how that goes that would be great.

doug-martin added a commit that referenced this pull request Sep 30, 2013
@doug-martin doug-martin merged commit 4e145e6 into C2FO:master Sep 30, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants