This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
Add a method to dataset/query to append a group of OR conditions to an e... #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n existing where clause
|
Tests failed due to a method name change, which I forgot to change in one test. This will be corrected when I amend this pull request to include the other permutations of and/or combinations. |
…d the inverse method (andGroupedOr) also
|
Doug requested andGroupedAnd and orGroupedOr methods but the output sql isn't grouping with parens in the same way as the others. |
doug-martin
added a commit
that referenced
this pull request
Dec 13, 2013
Add a method to dataset/query to append a group of OR conditions to an e...
doug-martin
added a commit
to doug-martin/patio
that referenced
this pull request
Dec 13, 2013
Merged
doug-martin
added a commit
to doug-martin/patio
that referenced
this pull request
Dec 13, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...xisting where clause, and added a small set of tests for it.
Changes
Added the andGroupedOr method to the dataset query object to allow adding a group of OR conditions to an existing where clause. For example ... AND ((x = 1) OR (x = 2)).