Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limbo: add 'features' set to testcases #17

Merged
merged 5 commits into from
Jul 7, 2023
Merged

limbo: add 'features' set to testcases #17

merged 5 commits into from
Jul 7, 2023

Conversation

woodruffw
Copy link
Collaborator

Closes #16.

@woodruffw
limbo: add 'features' set to testcases
d4bab19 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested review from alex and tnytown July 7, 2023 18:17
@woodruffw woodruffw self-assigned this Jul 7, 2023
@woodruffw
limbo: fix required-ness of features
b1fec17 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review July 7, 2023 18:24
@woodruffw
Copy link
Collaborator Author

NB: I named this features instead of tags (as in #16) to avoid confusion around the purpose here -- tags felt pretty generic.

tnytown
tnytown reviewed Jul 7, 2023
View reviewed changes
limbo/testcases/_core.py Outdated Show resolved Hide resolved
@woodruffw
_core: rename param
1f28acf 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Collaborator Author

Thinking about it more, I think features should really be list[Feature], where Feature is an enum. That'll give us the ability to document what each feature actually means.

@woodruffw
limbo: make feature an enum
98267e3 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from tnytown July 7, 2023 18:56
tnytown
tnytown reviewed Jul 7, 2023
View reviewed changes
limbo/testcases/_core.py Outdated Show resolved Hide resolved
@woodruffw
limbo: typing
e3354c7 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw requested a review from tnytown July 7, 2023 19:23
tnytown
tnytown approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@tnytown tnytown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit 927985b into main Jul 7, 2023
@woodruffw woodruffw deleted the ww/limbo-tags branch July 7, 2023 20:42
carl-wallace added a commit to baloo/x509-limbo that referenced this pull request May 12, 2024
@carl-wallace
Merge pull request C2SP#17 from carl-wallace/policy
eb52247 
restore use of newer clap version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnytown tnytown tnytown approved these changes

@alex alex Awaiting requested review from alex

Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema: support a tag field that implies optionality
2 participants
@woodruffw @tnytown