Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limbo: remove old ee_cert helper, SAN everywhere by default #42

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

woodruffw
Copy link
Collaborator

This removes the old ee_cert helper entirely, replacing it with Builder.leaf_cert.

As part of that, our default generation behavior is now to include SAN(dns="example.com") by default. This should make it easier to integrate the test suite.

Needs a semi-fine-toothed review, since this was mostly machine refactoring.

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw self-assigned this Oct 17, 2023
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll run this against my the pyca/cryptography branch and check that there aren't any unexpected failures.

@tetsuo-cpp
Copy link
Contributor

Oh, the other missing piece to this is that we need to call expected_peer_name on the Builder everywhere. I think the most practical way to do this is to make example.com the default value.

I've pushed 8c9183f to deal with that. The tests run fine with this change. Feel free to revert if you had other ideas.

@woodruffw
Copy link
Collaborator Author

Oh, the other missing piece to this is that we need to call expected_peer_name on the Builder everywhere. I think the most practical way to do this is to make example.com the default value.

Yeah, that makes sense to me, now that we're setting the SAN to a default of example.com.

@woodruffw woodruffw merged commit 762e0b5 into main Oct 18, 2023
6 checks passed
@woodruffw woodruffw deleted the ww/san-by-default branch October 18, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants