New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial RFC 5280 test cases #7

Merged

woodruffw merged 28 commits into main from rfc5280

Jul 11, 2023

Collaborator

woodruffw commented Jun 20, 2023 •

edited

Loading

See #1.

woodruffw added 3 commits

June 15, 2023 18:11


          assets: fix issuers

20a0b17

These were accidentally skipping a level.

Signed-off-by: William Woodruff <william@trailofbits.com>


          limbo: begin work on 5280 testcases

da7ea44

Signed-off-by: William Woodruff <william@trailofbits.com>


          Merge remote-tracking branch 'origin/main' into rfc5280

43d1e41

Signed-off-by: William Woodruff <william@trailofbits.com>

woodruffw mentioned this pull request

Testcase enumeration #1

Closed

24 tasks

woodruffw assigned woodruffw and tnytown

woodruffw and others added 4 commits

June 20, 2023 11:12


          reformat, linting

4e1fa79

Signed-off-by: William Woodruff <william@trailofbits.com>


          cleanup

79ec0e5

Signed-off-by: William Woodruff <william@trailofbits.com>


          limbo: add a stub webpki mod

01b3544

Signed-off-by: William Woodruff <william@trailofbits.com>


          testcases/rfc5280: critical aki, unknown ext

70479da

woodruffw commented

View reviewed changes

limbo/assets.py Outdated Show resolved Hide resolved

woodruffw commented

View reviewed changes

limbo/testcases/rfc5280.py Show resolved Hide resolved

woodruffw commented

View reviewed changes

limbo/testcases/rfc5280.py Outdated Show resolved Hide resolved

tnytown added 7 commits

June 30, 2023 18:21


          Merge remote-tracking branch 'origin/main' into rfc5280

28a073c


          limbo: replace v3_root_ca, more rfc5280 tests

439855b


          Merge remote-tracking branch 'origin/main' into rfc5280

43b43c5


          limbo.json: regenerate

d0c24a7

Signed-off-by: Andrew Pan <a@tny.town>


          limbo: AKI, SAN test cases

d30d511

Signed-off-by: Andrew Pan <a@tny.town>


          Merge remote-tracking branch 'origin/main' into rfc5280

79a198a


          limbo: conform to CA/B on partial wildcards

512cbe9

Signed-off-by: Andrew Pan <a@tny.town>

woodruffw commented

View reviewed changes

limbo/testcases/webpki.py Outdated Show resolved Hide resolved

tnytown and others added 8 commits

July 7, 2023 10:43


          Update limbo/testcases/webpki.py

d6ba2ef

Co-authored-by: William Woodruff <william@trailofbits.com>


          gocryptox509: implement skipping

cb0be5f

Signed-off-by: Andrew Pan <a@tny.town>


          limbo: rework Builder.intermediate_ca

8ce9927

Signed-off-by: Andrew Pan <a@tny.town>


          webpki: cryptography.io chain happy path test

5683e35

Signed-off-by: Andrew Pan <a@tny.town>


          Merge remote-tracking branch 'origin/main' into rfc5280

e8e873e

# Conflicts:
#	harness/gocryptox509/main.go


          gocryptox509: squash bug with ExpectedResult

1be4eb0

Signed-off-by: Andrew Pan <a@tny.town>


          make reformat

8b745af

Signed-off-by: Andrew Pan <a@tny.town>


          webpki: negative cryptography.io case

c1cd565

Signed-off-by: Andrew Pan <a@tny.town>

tnytown marked this pull request as ready for review

July 10, 2023 20:19

woodruffw commented

View reviewed changes

assets/cryptography.io.cer Outdated Show resolved Hide resolved

tnytown added 4 commits

July 10, 2023 17:44


          assets: cryptography.io.cer -> cryptography.io.pem

6d2a416

Signed-off-by: Andrew Pan <a@tny.town>


          webpki: chain of pain case

3b7c6f5

Signed-off-by: Andrew Pan <a@tny.town>


          webpki: chain_untrusted_root

c8722d7

Signed-off-by: Andrew Pan <a@tny.town>


          make reformat

7f1731d

Signed-off-by: Andrew Pan <a@tny.town>

woodruffw commented

View reviewed changes

assets/cryptography.io.pem Outdated Show resolved Hide resolved

woodruffw commented

View reviewed changes

limbo/assets.py Outdated Show resolved Hide resolved

tnytown added 2 commits

July 11, 2023 15:10


          limbo: use importlib.resources for _assets

2ff083d

Signed-off-by: Andrew Pan <a@tny.town>


          make reformat

809f5d0

Signed-off-by: Andrew Pan <a@tny.town>

Collaborator Author

woodruffw commented Jul 11, 2023

LGTM! We'll probably want to think about convenience APIs for pre-baked assets in the future, but this is all we need for now.

woodruffw merged commit 6182708 into main

5 checks passed

woodruffw deleted the rfc5280 branch

July 11, 2023 19:16

Collaborator Author

woodruffw commented Jul 11, 2023

Nice work @tnytown!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet