-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a CMakeFiles.txt
to be able to use current
from another project as a cmake
project.
#943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails on MacOS:
I suspect there's something wrong with either the flags ( |
…TF-8` when _linking_ is weird.
@mzhurovich let's close this one for now, in favor of #944. The latter makes smaller steps, tested through including on macOS. It's also more CCH-friendly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case in point: https://github.com/dkorolev/cmake_trivial_2023/blob/main/CMakeLists.txt#L32
To try:
Note: This will use up all the CPUs on the machine! The tests will build quickly though.
Also, the tests pass when run from a directory the full path name of which contains spaces. This is not the case as of now with our "standard" way to run the tests. Looks like
cmake
is doing some things right indeed!