-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CMakeLists.txt
and Makefile
for clean & fast builds of external projects that use Current.
#956
Conversation
Hi @mzhurovich! This was easier than I thought! Clean test:
This test is also run by a Github Action, both on Linux and on macOS. What this means now is that using Current, with fast incremental builds, and with a non-header-only Googletest, is just a matter of:
Thanks, |
@@ -0,0 +1,68 @@ | |||
# TODO(dkorolev): Consider intelligently re-running `cmake` from the `Makefile` if the set of source files has changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE(dkorolev), @mzhurovich, this was tested a long time ago in https://github.com/dkorolev/example_use_current_with_cmake, just cleaned up a bit and moved this into current
.'
@mzhurovich, added support for dynamic libraries too, and tested on Linux, WSL, and macOS! |
Probably best to review per commit, but, to get a feel, |
@dimacurrentai I have one question - why |
It needs to not find current/ in ../ and ../../, and maybe in ../../..
Where did you find it thought? That's my internal local run script!
…On Wed, Jan 3, 2024 at 00:04 Maxim Zhurovich ***@***.***> wrote:
@dimacurrentai <https://github.com/dimacurrentai> I have one question -
why q/q/q? =)
—
Reply to this email directly, view it on GitHub
<#956 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVDEKLXBQOUCJTD2NY6FYRDYMQVYLAVCNFSM6AAAAABBJPCE4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUGIYTQNRYGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.