Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

B 16906 tac parser #1

Merged
merged 14 commits into from
Aug 1, 2023
Merged

B 16906 tac parser #1

merged 14 commits into from
Aug 1, 2023

Conversation

cameroncaci
Copy link

Ticket

Summary

Added new tac package to the backend. This allows for the parsing of received transportation accounting codes exported via a .txt file.

See additional documentation here:
https://github.com/CACI-MIlMOVE/mymove-docs/blob/main/docs/backend/tget/parsing/transportation-account.md

Struct Changes

  • Added new struct for desired information from the .txt file
  • Added new struct representing the .txt file

Setup to Run the Code

How to test

N/A - Awaiting upstream dependencies

…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
… *Added TAC package and tests for initial TRDM .txt file handling *Added dummy data for a TAC file
…s for pruning expired tacs. Also added consolidation functionality for duplicate TACs found
…et values in test to prevent mismatched time.now. Fixed consildating function and test. Fixed expired tac test
Copy link

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, comments are thorough and explain through the steps well. Two thumbs up from me!

TevinAdams
TevinAdams previously approved these changes Jul 27, 2023
j-Rosenthal
j-Rosenthal previously approved these changes Jul 27, 2023
deandreJones
deandreJones previously approved these changes Jul 28, 2023
j-Rosenthal
j-Rosenthal previously approved these changes Jul 28, 2023
TevinAdams
TevinAdams previously approved these changes Jul 28, 2023
@j-Rosenthal
Copy link

Conflicts

…onger needed due to the updated TAC struct. Additionally, remodeled existing TAC parser package and tests to reflect the incoming sync with new TAC struct fields and pointers
@deandreJones deandreJones merged commit 77b1f84 into main Aug 1, 2023
14 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants