This repository has been archived by the owner on May 7, 2024. It is now read-only.
forked from transcom/mymove
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…nting Code (TAC) modifications. Includes the file record struct that is parsed from TRDM as well as the function to connect it to MilMoves internal TAC struct as the field names are different. Currently under proposal for finalized TAC struct.
…ymove into E-04364-tac-model-updates
… *Added TAC package and tests for initial TRDM .txt file handling *Added dummy data for a TAC file
…s for pruning expired tacs. Also added consolidation functionality for duplicate TACs found
…et values in test to prevent mismatched time.now. Fixed consildating function and test. Fixed expired tac test
cameroncaci
requested review from
deandreJones,
danieljordan-caci,
TevinAdams and
j-Rosenthal
July 25, 2023 20:10
danieljordan-caci
previously approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, comments are thorough and explain through the steps well. Two thumbs up from me!
TevinAdams
previously approved these changes
Jul 27, 2023
cameroncaci
dismissed stale reviews from TevinAdams and danieljordan-caci
via
July 27, 2023 14:57
8ad07fa
j-Rosenthal
previously approved these changes
Jul 27, 2023
deandreJones
previously approved these changes
Jul 28, 2023
j-Rosenthal
previously approved these changes
Jul 28, 2023
danieljordan-caci
previously approved these changes
Jul 28, 2023
TevinAdams
previously approved these changes
Jul 28, 2023
Conflicts |
…onger needed due to the updated TAC struct. Additionally, remodeled existing TAC parser package and tests to reflect the incoming sync with new TAC struct fields and pointers
cameroncaci
dismissed stale reviews from TevinAdams, danieljordan-caci, j-Rosenthal, and deandreJones
via
August 1, 2023 18:46
ebf2b35
j-Rosenthal
approved these changes
Aug 1, 2023
deandreJones
approved these changes
Aug 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Summary
Added new tac package to the backend. This allows for the parsing of received transportation accounting codes exported via a .txt file.
See additional documentation here:
https://github.com/CACI-MIlMOVE/mymove-docs/blob/main/docs/backend/tget/parsing/transportation-account.md
Struct Changes
Setup to Run the Code
How to test
N/A - Awaiting upstream dependencies