generalize io for Arc #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops wrong target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no fundamental reason to limit the io trait implementations on
Arcto onlyFile; they can equally be applied to anyArc<T> where &T: Trait.Arcisn't a fundamental type, so it's impossible for downstream crates to implementRead for Arc<LocalType>, thus this blanket impl is a non-breaking one (if I remembered the API evolution rules correctly).ATTN: this PR makes insta-stable API changes.
Now that the impl is generalized it might be more proper to live in a different file, but I did this from the web editor.