Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestrator parameters #320

Merged
merged 17 commits into from
May 21, 2024
Merged

Conversation

Carsonthemonkey
Copy link
Collaborator

Overview

Added functions for parsing, serializing, and validating a series of Orchestrator actions

Ticket

Pivotal Ticket

Contributions

  • Adds function for parsing string of actions into a list of tasks (actions are not defined as anything beyond task types as of now)
  • Adds function for validating that string of actions is in the correct format
  • Adds function for converting a list of tasks into an action string

Test

  • Adds unit test for parsing a single action, multiple actions, and invalid actions
  • Adds unit test for serializing a single action and multiple actions
  • Adds task for validating valid and invalid action strings

Documentation

  • Functions are documented with docstrings

Changelog

  • changelog updated

@Carsonthemonkey Carsonthemonkey requested a review from lawhead April 15, 2024 19:20
Copy link
Collaborator

@lawhead lawhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. I would just like some things named a bit differently to clarify the intent.

bcipy/orchestrator/parameters/actions.py Outdated Show resolved Hide resolved
bcipy/orchestrator/parameters/actions.py Outdated Show resolved Hide resolved
bcipy/orchestrator/parameters/actions.py Outdated Show resolved Hide resolved
bcipy/orchestrator/tests/test_actions.py Show resolved Hide resolved
@lawhead
Copy link
Collaborator

lawhead commented Apr 25, 2024

Try to get the checks passing before merging. I think there are some typing issues to address.

@Carsonthemonkey Carsonthemonkey merged commit 1103585 into session-orchestrator May 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants