Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Protocol Gui #333

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Conversation

Carsonthemonkey
Copy link
Collaborator

@Carsonthemonkey Carsonthemonkey commented Jul 19, 2024

Overview

Add ability to define task protocols in the experiment gui

Ticket

Pivotal Ticket

Contributions

  • Add additional dropdown that displays all available tasks
  • Add UI elements for reordering and removing tasks
  • Add protocol saving to experiment.json
  • Refactor formatting for create experiment button

Test

  • No testing for GUI besides manually inspecting app.

Documentation

  • Buttons in the new interface are clearly labeled and code is commented.

Changelog

  • Changelog updated

@Carsonthemonkey Carsonthemonkey requested a review from tab-cmd July 19, 2024 22:38
@Carsonthemonkey Carsonthemonkey marked this pull request as ready for review July 24, 2024 18:39
Copy link
Contributor

@tab-cmd tab-cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the up/down ordering. Thanks for the addition! What PR do we want to update BCInterface? Currently, it fails due to TaskType import. Looking at the tickets in pivotal it is not clear to me!

@Carsonthemonkey
Copy link
Collaborator Author

I like the up/down ordering. Thanks for the addition! What PR do we want to update BCInterface? Currently, it fails due to TaskType import. Looking at the tickets in pivotal it is not clear to me!

Since this the main entry point to starting a session it would make sense to me to wait until orchestrator is a little more fleshed out since it is required to run the task protocol. I think It would also make sense for me to refactor the GUI code before this since it will be affected by it.

@Carsonthemonkey Carsonthemonkey merged commit 6242845 into session-orchestrator Jul 24, 2024
6 checks passed
@tab-cmd tab-cmd deleted the experiment_protocol_gui branch November 4, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants