Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Research: add a template for Pull Requests #2

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[Documentation] Research: add a template for Pull Requests #2

merged 2 commits into from
Oct 12, 2023

Conversation

y-c-wang
Copy link
Collaborator

@y-c-wang y-c-wang commented Oct 12, 2023 •
edited
Loading

Description

This PR adds a template for Pull Requests for this repository in order to enhance engineering excellence.

Changes

  • Add a template for Pull Requests in .github/pull_request_template.md

Notes

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • Any changes to strings have been published to our translation tool
  • I conducted basic QA to assure all features are working
  • I requested code review from other team members

Resolved Issues

@y-c-wang y-c-wang added the documentation Improvements or additions to documentation label Oct 12, 2023
@y-c-wang y-c-wang self-assigned this Oct 12, 2023
@y-c-wang y-c-wang temporarily deployed to 2/merge October 12, 2023 16:51 — with GitHub Actions Inactive
@y-c-wang y-c-wang temporarily deployed to 2/merge October 12, 2023 16:53 — with GitHub Actions Inactive
@y-c-wang y-c-wang changed the title [Research] Documentation: add a template for Pull Requests [Documentation] Research: add a template for Pull Requests Oct 12, 2023
@y-c-wang y-c-wang linked an issue Oct 12, 2023 that may be closed by this pull request
Documentation: add a template for Pull Requests #1
Closed
@y-c-wang y-c-wang force-pushed the y-c-wang/pr-template branch from 9e278ea to 1663276 Compare October 12, 2023 17:28
@y-c-wang y-c-wang temporarily deployed to research October 12, 2023 17:28 — with GitHub Actions Inactive
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 1663276):

https://smartcampus-research--pr2-y-c-wang-pr-template-nfyv6fw0.web.app

(expires Thu, 19 Oct 2023 17:31:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1dca4624b78fea5f0ba14b85ab2d84e304903956

@y-c-wang y-c-wang merged commit 5b4fcbb into research Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@y-c-wang y-c-wang

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: add a template for Pull Requests
1 participant
@y-c-wang