feat: allow for specifying the order of population labels in Breakpoints.encode()
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryarm
changed the title
Breakpoints.encode()Breakpoints.encode()
mlamkin7
approved these changes
Nov 27, 2024
|
Thanks for the review, Michael! Going to leave this PR open until at least tues in case Jessica has any other comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that they can be made consistent across calls to
encode()on different bp filesAt the moment,
encode()will choose integers to pair with each population label in the order that the labels appear in the bp file. So "AMR" will be assigned a value of 0 if it appears first in the file and "EUR" will be assigned a value of 1 if it appears second, etc. But what if you want the same ordering across a bunch of bp files? Wouldn't it be great if there was a way to just specify the integers for each pop label? This is that solution.