Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings - More appropriate slider speeds #963

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Settings - More appropriate slider speeds #963

merged 2 commits into from
Aug 24, 2018

Conversation

mharis001
Copy link
Contributor

When merged this pull request will:

  • Change color setting sliders speed to an appropriate value
  • Currently, pressing one of the arrows moves the slider all the way left/right

@commy2
Copy link
Contributor

commy2 commented Aug 20, 2018

The same for the other slider?

@mharis001
Copy link
Contributor Author

That would have to depend on the range, currently it always changes by 1 using the arrows. Could make that 5%(?) of the range.

@commy2
Copy link
Contributor

commy2 commented Aug 20, 2018

Yeah, same as this one basically. 5 and 10 %.

@commy2 commy2 added this to the 3.8.1 milestone Aug 20, 2018
@mharis001 mharis001 changed the title Fix color setting slider speed Settings - More appropriate slider speeds Aug 20, 2018
@commy2 commy2 merged commit b75ca63 into CBATeam:master Aug 24, 2018
@mharis001 mharis001 deleted the fix-color-setting-sliders branch August 29, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.
2 participants
@mharis001 @commy2