rotation module improvement #3881
Conversation
|
preview: https://streamable.com/ajucek |
larryngton2
changed the title
|
It seems weird though. Can't know if it's render smoothing or slow rotations. |
there is a toggle for it sooo idk |
| private val smoothRotations by boolean("SmoothRotations", false) | ||
| private val smoothingFactor by float("SmoothFactor", 0.15f, 0.1f..0.9f) |
There was a problem hiding this comment.
Then make sure this is in a toggleable configurable at least, so it's "Smooth Rotation" -> "Factor". Make sure it's "Rotation", not "Rotations", so it matches the "ShowRotationVector"
There was a problem hiding this comment.
I'll work on it when I get on my pc
…mplement a class for smoothrotation
| @@ -41,11 +41,14 @@ import net.minecraft.util.Pair | |||
|
|
|||
| object ModuleRotations : Module("Rotations", Category.RENDER) { | |||
|
|
|||
| val showRotationVector by boolean("ShowRotationVector", false) | |||
| private val showRotationVector by boolean("ShowRotationVector", false) | |||
| private val smoothRotations by boolean("SmoothRotation", false) | |||
There was a problem hiding this comment.
It is off by default 👍🏻
| private fun smoothRotation(from: Rotation, to: Rotation): Rotation { | ||
| val diffYaw = to.yaw - from.yaw | ||
| val diffPitch = to.pitch - from.pitch | ||
| val smoothingFactor = 0.25f |
There was a problem hiding this comment.
smoothing factor is hardcoded as it should 👍🏻
There was a problem hiding this comment.
it should have been a slider inside a toggleableconfigurable but i lost 99.9% of my braincells trying to move all of this shit to a class
There was a problem hiding this comment.
bruh, just use a ToggleableConfigurable
|
can we get even more approvals 🙏 |
implements part of #3524