Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and content updates for README.md #161

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

larsks
Copy link
Member

@larsks larsks commented Jun 27, 2024

  • Consistent use of Markdown headings: children of an h1 heading should be
    h2 headings
  • Consistent line wrapping: previously, some paragraphs were line-wrapped
    and others were not. This commit makes all paragraphs unwrapped.
  • Use pip for installation rather than python setup.py
  • Make it easier to copy-and-paste most command examples by removing $
    shell prompts
  • Remove unnecessary GRANT commands from mysql instructions: % is a wildcard so 'esi_leap'@'%' already grants access to 'esi_leap'@'<database_ip>'
  • Simplify the "Container Installation" section

@larsks larsks changed the title fix/README Formatting and content updates for README.md Jun 27, 2024
- Consistent use of Markdown headings: children of an h1 heading should be
  h2 headings
- Consistent line wrapping: previously, some paragraphs were line-wrapped
  and others were not. This commit makes all paragraphs unwrapped.
- Use `pip` for installation rather than `python setup.py`
- Make it easier to copy-and-paste most command examples by removing `$`
  shell prompts
- Remove unnecessary `GRANT` commands from mysql instructions: `%` is a
  wildcard so `'esi_leap'@'%'` already grants access to
  `'esi_leap'@'<database_ip>'`
- Simplify the "Container Installation" section
Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember vaguely thinking that the '##' heading looked too big, but looking at it now it looks fine. Thanks!

```
git clone https://github.com/CCI-MOC/esi-leap
cd esi-leap
pip install .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit, I didn't realize you could do this.

@larsks larsks merged commit 23facb4 into CCI-MOC:master Jun 28, 2024
5 checks passed
@larsks larsks deleted the fix/README branch June 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants