Add command and workflow to validate rates.yaml #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to ensure that new changes do not introduce errors in rates.yaml. This commit adds a `validate-rates-file` command and an associated Github workflow that will use the new command to validate `rates.yaml` on pull requests. The validate-rates-file command knows how to generate github annotations [1] for pydantic validation errors and yaml parse errors. [1]: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message
|
The annotations added when running the validation workflow look like this:
Or this:
|
knikolla
approved these changes
May 28, 2024
naved001
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that new changes do not introduce errors in rates.yaml.
This commit adds a
validate-rates-filecommand and an associated Githubworkflow that will use the new command to validate
rates.yamlon pullrequests.
The validate-rates-file command knows how to generate github annotations 1
for pydantic validation errors and yaml parse errors.