Update the way we calculate SU*Hours for a project. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #17 |
The old method normalizes RAM and CPU ratio descrepancies. It calcualted vCPU hours and memory hours for each pod, summed it up at the project level and *then* calculated SU hours ( max(vcpu_hours, memory_hours/4). The new method avoids this by "assigning" fractional SUs to a pod, calculating SU hours at the pod level before summing it up at the project level. This accurately captures the SU usage. closes CCI-MOC#17
larsks
reviewed
Dec 14, 2023
* take care of removing temporary files * speed up tests
|
@larsks thanks for the feedback, I have addressed your comments with another commit. |
larsks
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method normalizes RAM and CPU ratio descrepancies. It calcualted vCPU hours and memory hours for each pod, summed it up at the project level and then calculated SU hours ( max(vcpu_hours, memory_hours/4).
The new method avoids this by "assigning" fractional SUs to a pod, calculating SU hours at the pod level before summing it up at the project level. This accurately captures the SU usage.
Closes #17