Implement how we gather GPU types. #49
Merged
+64
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ths cluster has multiple types of GPUs. To determine the type of GPUs we query the node labels where a pod requesting GPU was run, from that we can find exact model of the GPU. This commit updates the query that to get the node labels when we gather GPU usage. The merge metrics method is updated to keep the gpu_type. The GPU type for lenovo A100s is added and a corresponding SU is also created.
naved001
force-pushed
the
calculate-gpu-costs
branch
from
fe49c3c to
1451c1e
Compare
…ter nor do we know what it would be named, so I removing it. We can add it if it's added to the cluster. Also update the test to include A100SXM4 instead of A2
naved001
force-pushed
the
calculate-gpu-costs
branch
from
c4c3aa1 to
902162e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths cluster has multiple types of GPUs. To determine the type of GPUs we query the node labels where a pod requesting GPU was run, from that we can find exact model of the GPU.
This commit updates the query that to get the node labels when we gather GPU usage. The merge metrics method is updated to keep the gpu_type. The GPU type for lenovo A100s is added and a corresponding SU is also created.