-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update headers #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachimweyl
reviewed
Aug 30, 2023
joachimweyl
reviewed
Aug 30, 2023
joachimweyl
reviewed
Aug 30, 2023
joachimweyl
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Some headers aren't currently populated yet e.g. rate and cost.
naved001
force-pushed
the
update-headers
branch
from
August 30, 2023 20:34
78d8188
to
dd3326a
Compare
@joachimweyl I have added the column for "Project - Allocation ID" to this PR. |
joachimweyl
approved these changes
Aug 30, 2023
naved001
commented
Aug 30, 2023
naved001
commented
Aug 30, 2023
This was referenced Aug 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also modifies the tests.
The place for rate, cost and Institution* fields are blank for now because I added the headers but still need to work on calculating some of those values.