This adds mechanism to get gpu type based on the kubernetes node name #80
+144
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuanMPhm Thank you for the review, I have updated the PR. |
QuanMPhm
approved these changes
Oct 10, 2024
knikolla
reviewed
Oct 16, 2024
We now read from a file to get a static mapping of nodes and the GPU model on those nodes. This is used only when the labels on the nodes are missing.
naved001
force-pushed
the
feature/gpu-type-from-file
branch
from
e580008 to
19fa765
Compare
When the node to gpu map file isn't loaded then log a warning
naved001
force-pushed
the
feature/gpu-type-from-file
branch
from
4da8d8d to
846c93d
Compare
knikolla
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now read from a file to get a static mapping of nodes and the GPU model on those nodes. This is used only when the labels on the nodes are missing.