Implemeted nerc-rates repo into Openstack billing
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsks
approved these changes
Jun 13, 2024
larsks
approved these changes
Jun 13, 2024
naved001
requested changes
Jun 17, 2024
There was a problem hiding this comment.
@QuanMPhm This PR does not make it clear in the commit message that 2 arguments still need to be supplied via the command line instead of nerc-rates. It also doesn't mention a reason anywhere.
But anyway, I have proposed in the comments that we get those 2 remaining arguments from nerc-rates as well.
QuanMPhm
force-pushed
the
70/use_nerc_rates
branch
from
ea38d35 to
a715d0f
Compare
|
@naved001 I've applied your comments so far, updated the commit message, and will wait for further instructions for the missing A2 GPU rate. |
For now, because the rate for the A2 GPU is not in `nerc-rates`, even with the `--use-nerc-rates` arg set, the rate for the A2 GPU still needs to be provided via CLI
QuanMPhm
force-pushed
the
70/use_nerc_rates
branch
from
a715d0f to
c83d7c5
Compare
naved001
approved these changes
Jun 21, 2024
knikolla
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70.