Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify help text for --all and --status flags in esi lease list and offer list #58

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

skanthed
Copy link
Collaborator

  • Updated the help text for openstack esi lease list command to specify that --all shows all projects and --status any shows all statuses.
  • Ensured similar clarity for openstack esi offer list command.

Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized: we probably want additional text explaining that the default lease/offer list only shows leases/offers with a particular status (you can look at esi-leap to see which). I'd update these to say "Use --status 'any' to show leases with any status (by default only leases with XXXX and YYYY status are shown)".

@skanthed
Copy link
Collaborator Author

@tzumainn Updated that change.

@skanthed skanthed requested a review from tzumainn June 24, 2024 14:03
esileapclient/osc/v1/offer.py Outdated Show resolved Hide resolved
esileapclient/osc/v1/lease.py Outdated Show resolved Hide resolved
@skanthed
Copy link
Collaborator Author

skanthed commented Jun 24, 2024

https://github.com/CCI-MOC/esi-leap/blob/master/docs/esi-leap-api-ref.md
https://github.com/CCI-MOC/esi-leap/blob/master/docs/esi-leap-requirements.md

I referred to these two files and tested the command, which is what I understand.
Am I missing something @tzumainn ?

@tzumainn
Copy link
Contributor

Yeah - the code I linked shows the default statuses that will actually be returned.

@skanthed
Copy link
Collaborator Author

@tzumainn tzumainn merged commit 005dd5f into CCI-MOC:master Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants