Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for Python version #1014

Closed
wants to merge 7 commits into from

Conversation

lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl commented Mar 8, 2022

Summary/Motivation:

  • Update supported Python versions to 3.7 through 3.9
  • Remove version constraint for pywin32 since it shouldn't be needed anymore
    • EDIT: it seems that removing the constraint results in errors, and therefore we have to keep the pywin32 version pinned to the older 225

Changes proposed in this PR:

  • Remove Python 3.6 and add 3.9 to CI checks
  • Update setup.py with Python version requirements and updates

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.76%. Comparing base (a3fcb81) to head (d4bd429).
Report is 108 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1014   +/-   ##
=======================================
  Coverage   30.76%   30.76%           
=======================================
  Files         161      161           
  Lines       35793    35793           
  Branches     6041     6041           
=======================================
  Hits        11013    11013           
  Misses      23966    23966           
  Partials      814      814           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 8, 2022
@ksbeattie ksbeattie self-requested a review March 8, 2022 21:02
@lbianchi-lbl lbianchi-lbl changed the title Update requirements for Python version and pywin32 Update requirements for Python version Mar 15, 2022
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangunter
Copy link

@lbianchi-lbl I just ran into the Python 3.9+ not supported issue (since 3.10.x is default now), so I would suggest prioritizing a simple update to the install docs.

@dangunter
Copy link

Also a note on Windows in order to get the Foqus install (at least desktop shortcut) to actually work, I had to follow one of the more evil hacks suggested on this page https://stackoverflow.com/questions/58612306/how-to-fix-importerror-dll-load-failed-while-importing-win32api , namely copying the files pywintypes38.dll and pythoncom38.dll from the Conda environment Lib into my Windows system32 lib (!!!)

@lbianchi-lbl
Copy link
Contributor Author

Closing this in favor of #1036 (for the Python 3.9+ support) and #1037 (for the issues with creating a desktop shortcut on Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants