-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements for Python version #1014
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 30.76% 30.76%
=======================================
Files 161 161
Lines 35793 35793
Branches 6041 6041
=======================================
Hits 11013 11013
Misses 23966 23966
Partials 814 814 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lbianchi-lbl I just ran into the Python 3.9+ not supported issue (since 3.10.x is default now), so I would suggest prioritizing a simple update to the install docs. |
Also a note on Windows in order to get the Foqus install (at least desktop shortcut) to actually work, I had to follow one of the more evil hacks suggested on this page https://stackoverflow.com/questions/58612306/how-to-fix-importerror-dll-load-failed-while-importing-win32api , namely copying the files |
Summary/Motivation:
Remove version constraint forpywin32
since it shouldn't be needed anymorepywin32
version pinned to the older 225Changes proposed in this PR:
setup.py
with Python version requirements and updatesLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: