Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx Documentation Build Issue #1035

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Jun 7, 2022

Fixes/Addresses:

  • Recently, test runs have been failing due to Sphinx documentation build errors:
    14 WARNING: Invalid configuration value found: 'language = None'. Update your configuration to a valid langauge code. Falling back to 'en' (English).
    15 make: *** [Makefile:242: dummy] Error 1
    16 Error: Process completed with exit code 2.
  • The first warning is related to Sphinx Issue #10474 and PR #10481 where None was removed as a supported flag for the language entry. This update switches the flag to 'en' (the new default) to remove the warning.

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bpaul4 bpaul4 self-assigned this Jun 7, 2022
@bpaul4 bpaul4 marked this pull request as ready for review June 7, 2022 18:30
@bpaul4 bpaul4 requested review from ksbeattie and lbianchi-lbl June 7, 2022 18:31
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.58%. Comparing base (0537a52) to head (2bc01d1).
Report is 101 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   32.58%   32.58%           
=======================================
  Files         161      161           
  Lines       35856    35856           
  Branches     6047     6047           
=======================================
  Hits        11685    11685           
  Misses      23246    23246           
  Partials      925      925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit d5c9ac6 into CCSI-Toolset:master Jun 7, 2022
@bpaul4 bpaul4 deleted the doc-build-issue branch August 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants