Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad module path #1105

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

boverhof
Copy link
Member

@boverhof boverhof commented Jan 31, 2023

Fixes/Addresses:

Addresses #1101

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jan 31, 2023
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 33.32% // Head: 33.19% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (55c55dc) compared to base (7631418).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
- Coverage   33.32%   33.19%   -0.13%     
==========================================
  Files         161      161              
  Lines       36428    36428              
  Branches     5950     5950              
==========================================
- Hits        12138    12092      -46     
- Misses      23330    23369      +39     
- Partials      960      967       +7     
Impacted Files Coverage Δ
foqus_lib/gui/uq/uqSetupFrame.py 41.09% <0.00%> (ø)
foqus_lib/gui/basic_data/basicDataFrame.py 67.85% <0.00%> (-10.72%) ⬇️
...b/framework/sintervectorize/SinterFileVectorize.py 15.00% <0.00%> (-2.50%) ⬇️
foqus_lib/framework/sim/turbineLiteDB.py 0.00% <0.00%> (-2.24%) ⬇️
foqus_lib/framework/uq/ExperimentalDesign.py 53.16% <0.00%> (-1.90%) ⬇️
foqus_lib/framework/ouu/OUU.py 40.87% <0.00%> (-1.86%) ⬇️
foqus_lib/framework/uq/RawDataAnalyzer.py 25.60% <0.00%> (-1.22%) ⬇️
foqus_lib/gui/main/settingsFrame.py 27.04% <0.00%> (-0.82%) ⬇️
foqus_lib/framework/sim/turbineConfiguration.py 27.44% <0.00%> (-0.81%) ⬇️
foqus_lib/framework/uq/LocalExecutionModule.py 41.94% <0.00%> (-0.78%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ksbeattie ksbeattie enabled auto-merge (squash) February 14, 2023 21:21
@ksbeattie ksbeattie merged commit 2a32d11 into CCSI-Toolset:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants