Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sdoe tests #1115

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Added sdoe tests #1115

merged 5 commits into from
Mar 13, 2023

Conversation

franflame
Copy link
Contributor

Added sdoe tests, configuration files, and sample candidates

Resolves: #1083

Summary/Motivation:

Increase test coverage for sdoe core functionalities

Changes proposed in this PR:

  • add tests for distance.py, irsf.py, usf.py, nusf.py, and sdoe.py
  • add config.ini and candidates.csv files to test sdoe.run()

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@franflame franflame self-assigned this Mar 7, 2023
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 7, 2023
@ksbeattie
Copy link
Member

ksbeattie commented Mar 7, 2023

The .py files should get the updated copyright header once PR #1112 is merged.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.62 🎉

Comparison is base (99ae991) 33.31% compared to head (8640ee1) 34.94%.

❗ Current head 8640ee1 differs from pull request most recent head 19c1da4. Consider uploading reports for the commit 19c1da4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   33.31%   34.94%   +1.62%     
==========================================
  Files         161      161              
  Lines       36426    36426              
  Branches     5950     5950              
==========================================
+ Hits        12136    12729     +593     
+ Misses      23330    22715     -615     
- Partials      960      982      +22     

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

sotorrio1
sotorrio1 previously approved these changes Mar 7, 2023
Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbianchi-lbl
Copy link
Contributor

Coverage improvements due to this PR:

image

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until the copyright header has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve testing for SDoE
4 participants