Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation for ACM/VBA workaround #1118

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

Ryan-Hughes-8
Copy link
Contributor

Fixes/Addresses:

#1076 and #1044

Summary/Motivation:

Adding documentation for a workaround for connecting complicated ACM models to FOQUS.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@Ryan-Hughes-8 Ryan-Hughes-8 added the Documentation Update existing and adding new documents and tutorials label Mar 8, 2023
@Ryan-Hughes-8 Ryan-Hughes-8 requested a review from ksbeattie March 8, 2023 14:16
@Ryan-Hughes-8 Ryan-Hughes-8 self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (36d213b) 34.76% compared to head (6edacb6) 34.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   34.76%   34.76%           
=======================================
  Files         161      161           
  Lines       36296    36296           
  Branches     5940     5940           
=======================================
  Hits        12618    12618           
  Misses      22696    22696           
  Partials      982      982           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ryan-Hughes-8 Ryan-Hughes-8 marked this pull request as ready for review March 8, 2023 16:00
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 14, 2023
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie enabled auto-merge (squash) March 14, 2023 20:22
@ksbeattie ksbeattie merged commit dcb7e6d into CCSI-Toolset:master Mar 21, 2023
@Ryan-Hughes-8 Ryan-Hughes-8 deleted the acm_doc branch April 3, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update existing and adding new documents and tutorials Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants