Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced hypothesis testing #1123

Merged
merged 9 commits into from
Mar 19, 2023

Conversation

franflame
Copy link
Contributor

Summary/Motivation:

This introduces hypothesis testing to sdoe using the hypothesis framework

Changes proposed in this PR:

  • Add test function with hypothesis testing for distance.py
  • Improve handling of invalid inputs in distance.py
  • Add hypothesis as a developer dependency

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (114cbca) 34.80% compared to head (5e0e52d) 34.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   34.80%   34.95%   +0.14%     
==========================================
  Files         161      161              
  Lines       36426    36432       +6     
  Branches     5950     5953       +3     
==========================================
+ Hits        12679    12735      +56     
+ Misses      22756    22715      -41     
+ Partials      991      982       -9     
Impacted Files Coverage Δ
foqus_lib/framework/sdoe/distance.py 92.59% <100.00%> (+2.11%) ⬆️

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 14, 2023
@ksbeattie ksbeattie requested a review from sotorrio1 March 14, 2023 19:49
Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants