Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #1143

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

tarnold17
Copy link
Contributor

Fixes/Addresses:

Fixing various typos that I found in the FOQUS documentation while onboarding.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (16ff7ad) 37.22% compared to head (93cc814) 37.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   37.22%   37.22%   -0.01%     
==========================================
  Files         161      160       -1     
  Lines       36351    36343       -8     
  Branches     5944     5944              
==========================================
- Hits        13531    13528       -3     
+ Misses      21738    21733       -5     
  Partials     1082     1082              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl self-requested a review May 16, 2023 20:07
@lbianchi-lbl lbianchi-lbl added Documentation Update existing and adding new documents and tutorials Priority:Normal Normal Priority Issue or PR labels May 16, 2023
@lbianchi-lbl
Copy link
Contributor

Re: the macOS CI jobs not running, it looks like we might be using a version of the OS that's not available anymore:
image
image

I'll try opening a PR that addresses this. In the meantime, I don't see why we shouldn't merge this in, as the failures are with all probability unrelated.

@lbianchi-lbl lbianchi-lbl merged commit 267d8d6 into CCSI-Toolset:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update existing and adding new documents and tutorials Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants