Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler implementation of ordering algorithm #1157

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

sotorrio1
Copy link
Member

Fixes/Addresses:

issue #1155

Summary/Motivation:

mlrose-hiive was giving too many issues, moving away from it and using a library that uses pure python implementation of the TSP

Changes proposed in this PR:

  • import python-tsp
  • call different function to order candidate

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl self-requested a review August 15, 2023 19:56
…thm always start in the node zero and goes reversed to what the mlrose TSP used to do.
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (cb85b8f) 37.23% compared to head (6caf1b0) 37.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   37.23%   37.22%   -0.01%     
==========================================
  Files         160      160              
  Lines       36343    36339       -4     
  Branches     5944     5944              
==========================================
- Hits        13531    13527       -4     
  Misses      21730    21730              
  Partials     1082     1082              
Files Changed Coverage Δ
setup.py 0.00% <ø> (ø)
foqus_lib/framework/sdoe/order.py 96.15% <100.00%> (-0.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sotorrio1 sotorrio1 marked this pull request as ready for review August 15, 2023 22:38
@sotorrio1 sotorrio1 linked an issue Aug 15, 2023 that may be closed by this pull request
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie merged commit 807ac6b into CCSI-Toolset:master Aug 22, 2023
@sotorrio1 sotorrio1 deleted the issue-1155 branch August 23, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compartmentalize runtime dependencies on mlrose_hiive
3 participants