-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDoE: embedding SDoE plots into QDialog windows #1171
Conversation
It is likely that the tests are failing here because of the changes in the way the new QDialog windows are used. If so, then the tests themselves will need updating for this PR. Looking at the OUU and UQ gui-tests and code are structured could help. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 37.31% 37.67% +0.35%
==========================================
Files 160 160
Lines 36396 36439 +43
Branches 5956 5961 +5
==========================================
+ Hits 13582 13727 +145
+ Misses 21726 21609 -117
- Partials 1088 1103 +15 ☔ View full report in Codecov by Sentry. |
@lbianchi-lbl was right, the problem with SDoE GUI tests was the way sdoeAnalysisDialog was getting open. |
@sotorrio1 is this ready for review now? Were there more tests you were going to write? |
@ksbeattie Yes, it's ready for review. I added a couple of tests for plotting functions and tried to add some extra stuff into the existing GUI testing. @lbianchi-lbl might have some comments on the GUI testing stuff |
Fixes/Addresses:
Attempt to fix window stack ordering embedding matplotlib plots into QDialog windows
Summary/Motivation:
When plotting in SDoE, plots are shown as matplotlib objects and when the plots are closed the window stack ordering gets all messed up
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: