Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FOQUS documentation to include info on how to set paths for SimSinter and TurbineLite #1204

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Mar 18, 2024

update FOQUS documentation to include info on how to set paths for SimSinter and TurbineLite

Fixes/Addresses:

#1190

Summary/Motivation:

With version 3 of SimSinter and TurbineLite the applications were upgraded to 64-bit and thus their default installation paths changed. FOQUS default paths for these point to the 32-bit Windows default installation paths.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@kbuma kbuma requested review from boverhof and lbianchi-lbl March 18, 2024 17:08
@kbuma kbuma self-assigned this Mar 18, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR Documentation Update existing and adding new documents and tutorials labels Mar 19, 2024
Copy link
Member

@boverhof boverhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, hopefully it's obvious to people where they installed the packages.

@ksbeattie ksbeattie enabled auto-merge (squash) March 19, 2024 20:17
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.55%. Comparing base (820bbdb) to head (cf46811).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   38.52%   38.55%   +0.02%     
==========================================
  Files         163      163              
  Lines       36872    36872              
  Branches     6107     6107              
==========================================
+ Hits        14205    14216      +11     
+ Misses      21553    21539      -14     
- Partials     1114     1117       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie merged commit 0be08fc into CCSI-Toolset:master Mar 19, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update existing and adding new documents and tutorials Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants