Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #1251

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

ksbeattie
Copy link
Member

Fixes/Addresses:

The next step in #1162: this PR removes all unused imports as reported by pylint and adds that check to GHA.

Summary/Motivation:

Clean the code up a little bit.

Changes proposed in this PR:

  • Quite a few files changed, this will require some thorough testing to make sure it hasn't broken anything.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie changed the title Ksb remove unused imports Remove unused imports Nov 13, 2024
@ksbeattie ksbeattie self-assigned this Nov 13, 2024
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 13, 2024
@ksbeattie ksbeattie requested review from boverhof and kbuma November 13, 2024 20:34
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 38.47%. Comparing base (aad29e3) to head (e0ce1c6).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
foqus_lib/gui/sinter/sinter_config.py 0.00% 1 Missing ⚠️
foqus_lib/gui/uq/dialogTest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   38.87%   38.47%   -0.40%     
==========================================
  Files         165      164       -1     
  Lines       37281    37020     -261     
  Branches     5728     5728              
==========================================
- Hits        14492    14243     -249     
+ Misses      21662    21650      -12     
  Partials     1127     1127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@boverhof boverhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@boverhof boverhof merged commit 62534b8 into CCSI-Toolset:master Nov 13, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants