-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update keys call in cdscan for Python 3 #399
Conversation
@jasonb5 Ready for review. I wrote a script to check for any instances of |
@forsyth2 The changes look good but lets get the unit tests ran against this for sanity sake. I'm working on the dev-environment so you can run unit tests locally, let me get that into master and you can update and run the tests. |
@forsyth2 You can sync with master and use |
@forsyth2 @jasonb5 I just noticed line 77 and line 79 of the Makefile in master branch needs to be fixed. |
@muryanto1 I think this is fine, the reason for it was in a dev environment i want to start with the latest released version of everything. If we want to change this behavior lets do another PR so we can get this merged and move on with 8.2.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I managed to run the tests and got |
Update calls in cdscan for Python 3. Resolves #397.