fix test to close invalid json file (#657)

CDCgov · Jun 13, 2023 · 3bad598 · 3bad598
1 parent 3b52b40
commit 3bad598
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/phdi/linkage/link.py b/phdi/linkage/link.py
@@ -949,12 +949,15 @@ def read_linkage_config(config_file: pathlib.Path) -> List[dict]:
       various parts of linkage pass function.
     """
     try:
-        algo_config = json.load(open(config_file))
-        # Need to convert function keys back to column indices, since
-        # JSON serializes dict keys as strings
-        for rl_pass in algo_config.get("algorithm"):
-            rl_pass["funcs"] = {int(col): f for (col, f) in rl_pass["funcs"].items()}
-        return algo_config.get("algorithm", [])
+        with open(config_file) as f:
+            algo_config = json.load(f)
+            # Need to convert function keys back to column indices, since
+            # JSON serializes dict keys as strings
+            for rl_pass in algo_config.get("algorithm"):
+                rl_pass["funcs"] = {
+                    int(col): f for (col, f) in rl_pass["funcs"].items()
+                }
+            return algo_config.get("algorithm", [])
     except FileNotFoundError:
         raise FileNotFoundError(f"No file exists at path {config_file}.")
     except json.decoder.JSONDecodeError as e:

diff --git a/tests/not_valid_json_test.json b/tests/not_valid_json_test.json