Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Facility Details section to encounter info #2614

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

gordonfarrell
Copy link
Collaborator

PULL REQUEST

Summary

Update the Encounter section, creating a facility data subsection with some data from the previous encounter info section and a new Facility Contact Address field

Related Issue

Fixes #2506

Acceptance Criteria

  • New Facility Details section is added to Encounter Info
  • The following fields are added to that section in the order specified below:
    • Facility Name
    • Facility Address
    • Facility Contact
    • Facility Contact Address
    • Facility Type
    • Facility ID
  • The data in the fields should match the data found in the componentOf > encompassingEncounter > location > healthCareFacility section of the xml
  • If these fields are not present in the eCR document, they are added to the Unavailable Info section

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@sarahtress
Copy link
Collaborator

@gordonfarrell I think this looks good to me. it's a bit hard to do a full check because I don't have the source eCR xmls for what I'm looking at in the viewer, but I think the best way to check that will actually just be QAing all of the fields once the MVP changes are all done, rather than on a ticket by ticket basis

@gordonfarrell
Copy link
Collaborator Author

@gordonfarrell I think this looks good to me. it's a bit hard to do a full check because I don't have the source eCR xmls for what I'm looking at in the viewer, but I think the best way to check that will actually just be QAing all of the fields once the MVP changes are all done, rather than on a ticket by ticket basis

Sounds good thanks Sarah!

Copy link
Collaborator

@angelathe angelathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of small changes!

Also, since this ticket had some FHIR conversion, we probably want to update the data.sql file (npm run convert-seed-data -- --build)

Copy link
Collaborator

@angelathe angelathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gordonfarrell gordonfarrell added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 951a097 Sep 26, 2024
32 checks passed
@gordonfarrell gordonfarrell deleted the gordon/2506-facility-details branch September 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Facility Details" to Encounter Info
3 participants