-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Facility Details section to encounter info #2614
Conversation
@gordonfarrell I think this looks good to me. it's a bit hard to do a full check because I don't have the source eCR xmls for what I'm looking at in the viewer, but I think the best way to check that will actually just be QAing all of the fields once the MVP changes are all done, rather than on a ticket by ticket basis |
Sounds good thanks Sarah! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of small changes!
Also, since this ticket had some FHIR conversion, we probably want to update the data.sql
file (npm run convert-seed-data -- --build
)
containers/ecr-viewer/src/app/view-data/components/UnavailableInfo.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PULL REQUEST
Summary
Update the Encounter section, creating a facility data subsection with some data from the previous encounter info section and a new Facility Contact Address field
Related Issue
Fixes #2506
Acceptance Criteria
Facility Details
section is added toEncounter Info
componentOf > encompassingEncounter > location > healthCareFacility
section of the xmlUnavailable Info
sectionAdditional Information
Anything else the review team should know?
Checklist