Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure local prettier to align with CI config #2621

Closed
wants to merge 3 commits into from
Closed

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Sep 24, 2024

PULL REQUEST

Bob got really annoyed that there were formatter misalignments between CI prettier and local prettier, so he attempted to fix it. Think this one setting is the main misalignment, but also did an exact install of prettier against the CI version like they suggest

Now hitting save on our TSX files (🤞) shouldn't generate a bunch of comma-related changes that will just get reverted by the CI linter. Can test by running npx prettier --write src/app and notice that there aren't changes to any of the typescript files

@fzhao99 fzhao99 changed the title configure local prettier to align with CI styles configure local prettier to align with CI config Sep 24, 2024
@fzhao99 fzhao99 marked this pull request as ready for review September 24, 2024 19:36
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rob@Roberts-MacBook-Pro tefca-viewer % git status
On branch bob/test-lint
Your branch is up to date with 'origin/bob/test-lint'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   src/app/api/query/parsing-service.ts
	modified:   src/app/assets/TEFCA_Query_Connector_API.postman_collection.json
	modified:   src/app/tests/assets/BundleClinicalInfo.json
	modified:   src/app/tests/assets/BundleEcrMetadata.json
	modified:   src/app/tests/assets/BundleHAPIServer.json
	modified:   src/app/tests/assets/BundleLabInfo.json
	modified:   src/app/tests/assets/BundleMiscNotes.json
	modified:   src/app/tests/assets/BundlePatient.json
	modified:   src/app/tests/assets/BundleSexualOrientation.json
	modified:   src/app/tests/assets/BundleTravelHistory.json

this generated a few additional files when I ran the the rob@Roberts-MacBook-Pro tefca-viewer % npx prettier --write src/app command. nbd, but wanted to flag

@fzhao99
Copy link
Collaborator Author

fzhao99 commented Sep 24, 2024

Thanks for testing! Realized I assumed that those files getting caught was fine since I assumed they were prettierignored, but realizing now that's probs not a good assumption.

Zooming out here, think I might just leave as a local config since maintaining it against local setups might not be a great use of time for a papercut. Happy to chase it down if folks think differently, but don't want to spend too much time on this further.

@fzhao99 fzhao99 enabled auto-merge September 24, 2024 21:16
@fzhao99 fzhao99 disabled auto-merge September 24, 2024 21:16
@fzhao99 fzhao99 closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants