Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eicr author details #2623

Merged
merged 21 commits into from
Oct 9, 2024
Merged

add eicr author details #2623

merged 21 commits into from
Oct 9, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Sep 25, 2024

PULL REQUEST

Summary

What changes are being proposed?

  • Add new eICR Author details section to eCR Metadata
  • Switch from using Practitioner to PractitionerRole for authors
  • Remove organization information from practitioner

Related Issue

Fixes #2511

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

image

@BobanL BobanL marked this pull request as ready for review September 27, 2024 19:16
@sarahtress
Copy link
Collaborator

@BobanL this looks good to me, thanks!

Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with multiple authors and everything looks good!

@BobanL BobanL added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 565256e Oct 9, 2024
32 checks passed
@BobanL BobanL deleted the boban/2511-eICR-author-details branch October 9, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "eICR Author Details" section to eCR Metadata
3 participants