Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pagination when there are 0 results #2847

Merged
merged 2 commits into from
Nov 1, 2024
Merged

fix pagination when there are 0 results #2847

merged 2 commits into from
Nov 1, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Oct 31, 2024 •
edited
Loading

PULL REQUEST

Summary

When total count of results is 0 only show 1 page and 0-0 results rather than infinite pages and 1-0 results

Additional Information

Before:
image

Now:
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@BobanL BobanL marked this pull request as ready for review November 1, 2024 10:54
mcmcgrath13
mcmcgrath13 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mcmcgrath13 mcmcgrath13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@BobanL BobanL added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 6a41315 Nov 1, 2024
11 checks passed
@BobanL BobanL deleted the boban/fix-pagination-1 branch November 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmcgrath13 mcmcgrath13 mcmcgrath13 approved these changes

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth is a code owner

@angelathe angelathe Awaiting requested review from angelathe angelathe is a code owner

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell gordonfarrell is a code owner

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight JNygaard-Skylight is a code owner

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight austin-hall-skylight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobanL @mcmcgrath13