Fix FHIR Conversion for Specimen in Lab Info #2858
Conversation
angelathe
force-pushed
the
angela/2724-bug-lab-specimen
branch
from
143e80f to
7ec6bc2
Compare
angelathe
requested review from
BobanL,
lina-roth,
mcmcgrath13,
gordonfarrell,
JNygaard-Skylight and
austin-hall-skylight
@JNygaard-Skylight TY! Just added. |
| @@ -45,11 +45,15 @@ | |||
| {% endif -%} | |||
| {% elsif comp.procedure.participant.participantRole.id.displayName -%} | |||
| {% assign specValue = comp.procedure.participant.participantRole.id.displayName -%} | |||
| {% elsif entry.organizer.component.procedure.participant.participantRole.playingEntity.code.displayName -%} | |||
| {% assign specValue = comp.procedure.participant.participantRole.playingEntity.code.displayName -%} | |||
| {% elsif comp.procedure.participant.participantRole.playingEntity.code.originalText._ %} | |||
There was a problem hiding this comment.
would it be worth pulling out comp.procedure.participant.participantRole.playingEntity after line 41 or so? it might improve readability in this case
There was a problem hiding this comment.
@mcmcgrath13 TY, just fixed!
| {% elsif comp.procedure.participant.participantRole.playingEntity.code.originalText._ %} | ||
| {% assign specValue = comp.procedure.participant.participantRole.playingEntity.code.originalText._ -%} | ||
| {% elsif comp.procedure.participant.participantRole.playingEntity.code.displayName -%} | ||
| {% assign specValue = comp.procedure.participant.participantRole.playingEntity.code.displayName -%} |
There was a problem hiding this comment.
this isn't a pattern I'v come across before - am I understanding correctly that this specValue is kind of "attached" to to the component and then available for use elsewhere? (basically mutating it vs just computing and using locally?)
There was a problem hiding this comment.
It's not attached to the component, but specValue is accessible within the template it's created in, even across include statements. So now it's made available across _entry -> _entry_organizer_component -> Resource/_Observation`, where it finally gets used.
PULL REQUEST
Summary
Related Issue
Fixes #2724
Acceptance Criteria
Screenshot:
6a6bcd7d-7bad-48f6-9e0b-39a4ec9e063eBefore:
After:
Checklist
Example eCRs from QA process: