Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom 404 page #2876

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Add custom 404 page #2876

merged 13 commits into from
Nov 8, 2024

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Nov 8, 2024

PULL REQUEST

Summary

  • Create custom 404 page
  • Update error handling on view-data
  • Make changes to Back button to allow for customization and it was a little bit off center 🤏

Related Issue

Fixes #2850

Acceptance Criteria

  • When a user encounters a 404 this page is displayed
  • In non-integrated mode, a button is displayed that returns the user to the eCR library
  • In integrated mode there is no button

Additional Information

404 Page:
image

Back button on /view-data
before:
image

now:
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@BobanL
Copy link
Collaborator Author

BobanL commented Nov 8, 2024

@ashton-skylight - ready for review!

@ashton-skylight
Copy link
Collaborator

This looks great, Boban! Two minor changes that weren't reflected in the design, but might create more visual continuity:

  1. Change the 404 button text to "Back to eCR Library"
  2. On the 404 page, modify the spacing between the blue box and the button to be 24 or 32 px. It needs a little more breathing room

@BobanL BobanL marked this pull request as ready for review November 8, 2024 15:32
@lina-roth lina-roth added this pull request to the merge queue Nov 8, 2024
@BobanL BobanL removed this pull request from the merge queue due to a manual request Nov 8, 2024
Add not found on non-integrated viewer
@BobanL BobanL enabled auto-merge November 8, 2024 19:25
@BobanL BobanL added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 6239898 Nov 8, 2024
11 checks passed
@BobanL BobanL deleted the boban/2850-four-oh-four-page branch November 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Page not found" error page
3 participants