add ecr retrieval failed page #2882
Conversation
|
Awesome! Thanks Lina |
lina-roth
requested review from
BobanL,
mcmcgrath13,
angelathe,
gordonfarrell,
JNygaard-Skylight and
austin-hall-skylight
and removed request for
ashton-skylight
| <div className="margin-0"> | ||
| <b>Contact support:</b> If the problem persists, please reach out to | ||
| your eCR coordinator | ||
| <br /> to troubleshoot the issue with the DIBBs team. |
There was a problem hiding this comment.
why do we need the <br /> here - should we instead defer to css to make sure the wrapping happens appropriately?
There was a problem hiding this comment.
id normally agree but this being a static page with content that is unlikely to change, I dont feel like using text-wrap over "br" is really much of a difference
There was a problem hiding this comment.
how does it look on mobile?
There was a problem hiding this comment.
I need to double check but I dont think we are concerned with mobile for this app
There was a problem hiding this comment.
thanks! I could see it being weird at some widths, but if we're not worried about mobile, those odds are way low and I agree it doesn't make much difference here
There was a problem hiding this comment.
though I suppose things could get weird again if someone has different font sizes set on their settings? 🤔
There was a problem hiding this comment.
i asked Emma and she said "our assumption is that all users will be in a desktop/workplace setting"
PULL REQUEST
Summary
Related Issue
Fixes #2851
Acceptance Criteria
Checklist