Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parsing and saving of multiple rule summaries for one condition #2923

Merged
merged 31 commits into from
Nov 22, 2024

Conversation

gordonfarrell
Copy link
Collaborator

@gordonfarrell gordonfarrell commented Nov 18, 2024

PULL REQUEST

Summary

Updates parsing to return lists of summaries per condition. Then, for either postgres or sql server, loops through the list to save all conditions

Related Issue

Fixes #2922

Acceptance Criteria

  • The message parser returns an array of rule summaries per condition
  • Metadata saving loops through all arrays and saves conditions and rules along with their relationships

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@gordonfarrell gordonfarrell marked this pull request as ready for review November 21, 2024 16:23
@gordonfarrell gordonfarrell requested a review from BobanL November 21, 2024 16:23
Copy link
Collaborator

@JNygaard-Skylight JNygaard-Skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gordonfarrell gordonfarrell added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit dc2094d Nov 22, 2024
19 checks passed
@gordonfarrell gordonfarrell deleted the gordon/nested-array-of-summaries branch November 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse and save all rule summaries where multiple exist for one condition
2 participants