-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor save service response object #3018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobanL
requested review from
lina-roth,
mcmcgrath13,
angelathe,
gordonfarrell,
JNygaard-Skylight and
austin-hall-skylight
December 10, 2024 16:46
mcmcgrath13
reviewed
Dec 10, 2024
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Show resolved
Hide resolved
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3018 +/- ##
==========================================
- Coverage 86.00% 85.67% -0.34%
==========================================
Files 162 25 -137
Lines 10855 1424 -9431
==========================================
- Hits 9336 1220 -8116
+ Misses 1519 204 -1315
Flags with carried forward coverage won't be shown. Click here to find out more. |
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Show resolved
Hide resolved
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Show resolved
Hide resolved
mcmcgrath13
reviewed
Dec 10, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Show resolved
Hide resolved
mcmcgrath13
reviewed
Dec 11, 2024
containers/ecr-viewer/src/app/api/save-fhir-data/save-fhir-data-service.ts
Outdated
Show resolved
Hide resolved
…a-service.ts Co-authored-by: Mary McGrath <m.c.mcgrath13@gmail.com>
mcmcgrath13
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary