Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor save service response object #3018

Merged
merged 20 commits into from
Dec 11, 2024
Merged

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 10, 2024

PULL REQUEST

Summary

  • No longer return NextResponse from service since it's more difficult to read and handle in the service layer
  • Do not return error messages in response since it may leak information (see a similar code scanning issue).
  • Save both fhir bundle and metadata async
  • Remove pool.close() since it isn't recommended.

@BobanL BobanL changed the title Boban/refactor save service Refactor save service Dec 10, 2024
@BobanL BobanL changed the title Refactor save service Refactor save service response object Dec 10, 2024
@BobanL BobanL marked this pull request as ready for review December 10, 2024 16:45
@BobanL BobanL requested a review from mcmcgrath13 December 10, 2024 18:54
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (89f3e8d) to head (ff6ddb9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
- Coverage   86.00%   85.67%   -0.34%     
==========================================
  Files         162       25     -137     
  Lines       10855     1424    -9431     
==========================================
- Hits         9336     1220    -8116     
+ Misses       1519      204    -1315     
Flag Coverage Δ
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 137 files with indirect coverage changes

@BobanL BobanL requested a review from mcmcgrath13 December 11, 2024 13:29
@BobanL BobanL added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 2c516ff Dec 11, 2024
16 checks passed
@BobanL BobanL deleted the boban/refactor-save-service branch December 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants