Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sql server pool issues #3059

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix sql server pool issues #3059

wants to merge 8 commits into from

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 13, 2024

PULL REQUEST

Summary

  • Currently there are scenarios where transactions are open, but NOT closed. This can cause all connections to be open and not allowing any new connections
  • Refactor condition service layer to not use transactions at all and to simply return an array of conditions

Additional Information

Proof it still works:
image

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.69%. Comparing base (fe69608) to head (4aa90b2).

Files with missing lines Patch % Lines
...c/app/api/save-fhir-data/save-fhir-data-service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3059      +/-   ##
==========================================
+ Coverage   86.54%   87.69%   +1.14%     
==========================================
  Files         215       79     -136     
  Lines       13432     4005    -9427     
  Branches      667      662       -5     
==========================================
- Hits        11625     3512    -8113     
+ Misses       1786      484    -1302     
+ Partials       21        9      -12     
Flag Coverage Δ
ecr-viewer 88.80% <91.30%> (-0.03%) ⬇️
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration 85.67% <ø> (ø)
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tainers/ecr-viewer/src/app/api/conditions/route.ts 100.00% <100.00%> (ø)
...iners/ecr-viewer/src/app/api/conditions/service.ts 100.00% <100.00%> (+3.44%) ⬆️
...c/app/api/save-fhir-data/save-fhir-data-service.ts 33.80% <0.00%> (ø)

... and 142 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant