Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ecr schemas to extract the first 10 labs #564

Merged
merged 8 commits into from
May 10, 2023

Conversation

DanPaseltiner
Copy link
Collaborator

PULL REQUEST

Summary

This PR updates the eCR schemas in the message parser and kafka to delta services to extract the first 10 labs from an eCR instead of just the first 2

Related Issue

Fixes #542 and #543

Copy link
Contributor

@BradySkylight BradySkylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #564 (d9f53bc) into main (08b7733) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files          45       45           
  Lines        2479     2479           
=======================================
  Hits         2392     2392           
  Misses         87       87           
Flag Coverage Δ
unit-tests 96.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@BradySkylight BradySkylight merged commit 05358b5 into main May 10, 2023
@BradySkylight BradySkylight deleted the update-ecr-schemas branch May 10, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update schema of message parsing service to accommodate COVID filtering needs
2 participants